Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Document how to enable color on dark mode #29340

Merged
merged 15 commits into from
Oct 28, 2021

Conversation

Wimukti
Copy link
Contributor

@Wimukti Wimukti commented Oct 27, 2021

Preview: https://deploy-preview-29340--material-ui.netlify.app/components/app-bar/#enable-color-on-dark
Close #28962

Summary

  • Added a demo in the "Enable Color on Dark" section.
  • Added code block showing how the AppBar color behavior in dark mode can be overwritten with enableColorOnDark, for both the following cases
    - Enable color on dark for specific elements via prop
    - Affect all App Bar elements via theme
  • The section in the documentation about this: https://mui.com/components/app-bar/#enable-color-on-dark

image

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 27, 2021

No bundle size changes

Generated by 🚫 dangerJS against c089bb6

@Wimukti
Copy link
Contributor Author

Wimukti commented Oct 27, 2021

@siriwatknp Can you review this?

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: app bar This is the name of the generic UI component, not the React module! labels Oct 27, 2021
@oliviertassinari oliviertassinari changed the title [docs] Added a demo in Enable color on dark mode demo [docs] Document how to enable color on dark mode Oct 27, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 27, 2021

I have spent 10 minutes pushing new commits, to simplify the demo.


As a side note for the maintainers, the DX for creating this demo with a script to build the preview is not this great. I had to run the yarn docs:typescript:formatted script multiple times to settle on a preview that really felt great when reading the docs. It feels slower than before.

@Wimukti
Copy link
Contributor Author

Wimukti commented Oct 27, 2021

@oliviertassinari Thank you so much for reviewing the PR.

Wimukti and others added 2 commits October 28, 2021 07:02
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@Wimukti
Copy link
Contributor Author

Wimukti commented Oct 28, 2021

Argos Expected — Waiting for status to be reported is not passing. are there any suggestions to pass that check? I have configured Argos CI to my fork as well.

@siriwatknp
Copy link
Member

I have configured Argos CI to my fork as well.

I am not sure about this but normally you don't need to do that. Does it make Argos stuck? @oliviertassinari

@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 28, 2021

@siriwatknp The CI is running on the branch of @Wimukti's fork material-ui repository. The CI should be running as a PR on this repository instead. It can't work.

@oliviertassinari oliviertassinari removed their request for review October 28, 2021 10:56
@oliviertassinari oliviertassinari merged commit b399a0a into mui:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: app bar This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AppBar] Color does not apply in dark mode
4 participants