-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Document how to enable color on dark mode #29340
[docs] Document how to enable color on dark mode #29340
Conversation
…enable-color-on-dark-mode-demo
…enable-color-on-dark-mode-demo
…enable-color-on-dark-demo
@siriwatknp Can you review this? |
I have spent 10 minutes pushing new commits, to simplify the demo. As a side note for the maintainers, the DX for creating this demo with a script to build the preview is not this great. I had to run the |
@oliviertassinari Thank you so much for reviewing the PR. |
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Argos Expected — Waiting for status to be reported is not passing. are there any suggestions to pass that check? I have configured Argos CI to my fork as well. |
I am not sure about this but normally you don't need to do that. Does it make Argos stuck? @oliviertassinari |
@siriwatknp The CI is running on the branch of @Wimukti's fork material-ui repository. The CI should be running as a PR on this repository instead. It can't work. |
Preview: https://deploy-preview-29340--material-ui.netlify.app/components/app-bar/#enable-color-on-dark
Close #28962
Summary
- Enable color on dark for specific elements via prop
- Affect all App Bar elements via theme