-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix about page flags #29314
[docs] Fix about page flags #29314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Nice.
We could store the flags in our repo (it's just a few pngs after all) and not ever worry about another service being down again. |
We use different URL for the autocomplete countries, maybe we can use the same? https://github.com/mui-org/material-ui/blob/master/docs/src/pages/components/autocomplete/CountrySelect.tsx#L19 |
I suggest improving it later (maybe in the next quarter). @mbrookes your call. |
Nice to see that we have consolidated on a single flag provider (same as https://deploy-preview-29314--material-ui.netlify.app/components/autocomplete/#country-select). The downside of this one is that the flag aren't squared, it doesn't provide the same visual output, but it's fine 👍
@mnajdova I gave it a try, the png yield icons that don't look as great as the SVG (compression), the png is more efficient for the bandwidth, it's really true when the flag is complex.
I would anticipate this to be more time-consuming than changing the CDN provider every few years. |
Preview: https://deploy-preview-29314--material-ui.netlify.app/about/