[system] Improve breakpoints resolver function #29300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@material-ui/core: parsed: +0.10% , gzip: +0.11% |
hbjORbj
added
component: Grid
hbjORbj
changed the title
hbjORbj
requested review from
siriwatknp,
mnajdova,
michaldudak and
eps1lon
and removed request for
siriwatknp
siriwatknp
reviewed
Oct 26, 2021
mnajdova
reviewed
Oct 26, 2021
| // compute base for responsive values; e.g., | ||
| // [1,2,3] => {xs: true, sm: true, md: true} | ||
| // {xs: 1, sm: 2, md: 3} => {xs: true, sm: true, md: true} | ||
| function computeBreakpointsBase(breakpointValues, themeBreakpoints) { |
There was a problem hiding this comment.
Nice that we have this extracted :)
mnajdova
reviewed
Oct 27, 2021
mnajdova
reviewed
Oct 27, 2021
mnajdova
approved these changes
Oct 27, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26773
Closes #29175
Bugs prior to this PR:
spacing,direction,rowSpacing,columnSpacing, are not resolved correctly; e.g.,direction={{sm: 'row', xs: 'column'}} stays ascolumn` in all window sizes.columns={{ xs: 4, sm: 8, md: 12 }}andcolumns=[4,8,12]behave differently.spacinganddirection, are not resolved correctly; e.g.,direction={{sm: 'row', xs: 'column'}} stays ascolumn` in all window sizes.After this PR: