-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[codemod] Add codemod parser flag (#29059) #29229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 First awesome contribution! I have tested locally, it works!
I would advise against merging this. The codemod cli is a convenience helper not a replacement for the |
Thanks for the info. Do you see another way to fix #29059? |
I'm done. |
Why was the issue closed? |
👋🏽 I opened the original ticket. As a user of material UI and flow, I would expect to be able to use the upgrade script like so:
And for it to not crash. We have hundreds of files in our codebase that we use material UI, as the script currently is written only about 20% files actually get converted. The script crashes anytime there is a maybe flow type (definition here) which I imagine a lot of users who use flow also use. Thank you so much! |
@mnajdova I am good with this change, what do you think? (at least I don't see other ways because we force the parser in the current version) |
Thanks all! If I |
The codemod release will be next week around Monday. |
@siriwatknp thanks so much! Where do I check to see if the code release went out/did it go out? |
You can check it here (the next release is likely 5.0.7). https://github.com/mui-org/material-ui/releases |
Fix for #29059. Adds that ability to pass jscodeshift parser options to codemod. Is important for users using flowtype who are doing migrations to v5.0.