[DateRangePicker] Fix DateRangePickerDayProps interface
#29067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookes
added
the
component: date range picker
hbjORbj
changed the title
DateRangePickerDayProps interface
hbjORbj
force-pushed
the
fix-issue-28373
branch
from
44d6435 to
5e2d816
Compare
siriwatknp
reviewed
Dec 2, 2021
| @@ -41,7 +41,8 @@ export interface DateRangePickerDayClasses { | |||
|
|
|||
| export type DateRangePickerDayClassKey = keyof DateRangePickerDayClasses; | |||
|
|
|||
| export interface DateRangePickerDayProps<TDate> extends Omit<PickersDayProps<TDate>, 'classes'> { | |||
| export interface DateRangePickerDayProps<TDate = unknown> | |||
There was a problem hiding this comment.
Looking at packages/mui-lab/src/themeAugmentation/props.d.ts. Shouldn't it be like this instead?
export interface LabComponentsPropsList {
MuiAvatarGroup: AvatarGroupProps;
MuiCalendarPicker: CalendarPickerProps<unknown>;
MuiCalendarPickerSkeleton: CalendarPickerSkeletonProps;
MuiClockPicker: ClockPickerProps<unknown>;
MuiDatePicker: DatePickerProps;
MuiDateRangePickerDay: DateRangePickerDayProps<unknown>;
There was a problem hiding this comment.
If we do this MuiDateRangePickerDay: DateRangePickerDayProps<unknown>;,
do we need to set the default value here? export interface DateRangePickerDayProps<TDate = unknown>.
I think we only need either? Correct me if I am wrong.
There was a problem hiding this comment.
I don't think the default type is needed.
siriwatknp
requested changes
Dec 2, 2021
hbjORbj
force-pushed
the
fix-issue-28373
branch
from
98dd124 to
7afa8c2
Compare
siriwatknp
approved these changes
Dec 2, 2021
|
@jonathanrtuck Thanks for bringing this up! |
hbjORbj
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #28373.
Problem:
Solution:
MuiDatePicker,MuiDateTimePicker, etc…) of providingunknownas a default value forTDate.