-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ListItem] allowing for nestedindicator with righticonbutton presents #2898
Conversation
@gobadiah Could you add an example in the documentation, so we can check it out? |
@oliviertassinari I added a right icon button in the nested list example, you can check it out. |
Thanks. The render method of ths |
@oliviertassinari Yeah I agree with you. It's gonna be a bit hard though. But the idea is great 👍 👍 More composibility => easier customization + optimization + easier maintenance. |
@oliviertassinari I'm sure you already know my answer 🎉 🙌 👍 |
That being said, maybe the best time to take this on (the breaking up of the render method into internal components) is when we clean up the directories and import structure. |
I can count 3-4 issues opened regarding this. I do think it's a great idea. But we have to give it some time. We plan on making every component stateless and standard so they can be wrapped inside state handling wrappers. |
It looks like this PR got slightly derailed by a discussion about composability, but having tried the example, I'm not sure we should merge this (at least not in its current form). There's something about the resulting UI that doesn't feel right. @callemall/material-ui ? |
@mbrookes I agree. |
@gobadiah - thanks for the contribution 👍, and sorry we couldn't use it this time. |
While working on nested lists, I have found a need for having the right nested button, plus another one (in my case it was a trash icon button for deleting that line and all the nested lines included).
I wonder if the state open / close shouldn't go into a prop, so that the user can decide whether or not to open the nested items regardless of the nested indicator ?