Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ListItem] allowing for nestedindicator with righticonbutton presents #2898

Closed
wants to merge 3 commits into from

Conversation

gobadiah
Copy link
Contributor

While working on nested lists, I have found a need for having the right nested button, plus another one (in my case it was a trash icon button for deleting that line and all the nested lines included).

I wonder if the state open / close shouldn't go into a prop, so that the user can decide whether or not to open the nested items regardless of the nested indicator ?

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jan 12, 2016
@oliviertassinari
Copy link
Member

@gobadiah Could you add an example in the documentation, so we can check it out?

@oliviertassinari oliviertassinari added PR: Needs Review and removed docs Improvements or additions to the documentation labels Jan 12, 2016
@gobadiah
Copy link
Contributor Author

@oliviertassinari I added a right icon button in the nested list example, you can check it out.

@oliviertassinari
Copy link
Member

Thanks. The render method of ths ListItem is starting to be far too big: 300 lines.
I think that it would be good to make it composable. I mean break it down into smaller bits, like what we plan to do with the TextField (#2555)
@alitaheri @newoga Though?

@alitaheri
Copy link
Member

@oliviertassinari Yeah I agree with you. It's gonna be a bit hard though. But the idea is great 👍 👍 More composibility => easier customization + optimization + easier maintenance.

@newoga
Copy link
Contributor

newoga commented Jan 22, 2016

@oliviertassinari I'm sure you already know my answer 🎉 🙌 👍

@newoga
Copy link
Contributor

newoga commented Jan 22, 2016

That being said, maybe the best time to take this on (the breaking up of the render method into internal components) is when we clean up the directories and import structure.

@alitaheri
Copy link
Member

I wonder if the state open / close shouldn't go into a prop, so that the user can decide whether or not to open the nested items regardless of the nested indicator

I can count 3-4 issues opened regarding this. I do think it's a great idea. But we have to give it some time. We plan on making every component stateless and standard so they can be wrapped inside state handling wrappers.

@mbrookes
Copy link
Member

mbrookes commented Mar 2, 2016

It looks like this PR got slightly derailed by a discussion about composability, but having tried the example, I'm not sure we should merge this (at least not in its current form). There's something about the resulting UI that doesn't feel right.

@callemall/material-ui ?

@mbrookes mbrookes self-assigned this Mar 3, 2016
@oliviertassinari
Copy link
Member

@mbrookes I agree.

@mbrookes
Copy link
Member

mbrookes commented Mar 5, 2016

@gobadiah - thanks for the contribution 👍, and sorry we couldn't use it this time.

@zannager zannager added the component: list This is the name of the generic UI component, not the React module! label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: list This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants