Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Add product core page #27952

Merged
merged 226 commits into from
Sep 1, 2021
Merged

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Aug 25, 2021

@siriwatknp
Copy link
Member Author

@oliviertassinari

  1. fixed
  2. agree, updated.
  3. agree, updated.
  4. nice catch, fixed.
  5. good point, change to responsive instead @danilo-leal what do you think about it?
  6. changed to h2, h3 instead but for which one should be h2, I am not sure.
  7. fixed
  8. @danilo-leal any component you want to replace the DatePicker? or should we go with DatePicker for now?

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siriwatknp @oliviertassinari

Just pushed a bunch of changes. Regarding bullet nº8, I've removed the date picker and added/tweaked some of the components there. I focused on interactivity instead of a simple display of components, so most of them you can interact and play a bit.

Great work, Jun, looking awesome! The interactive responsive slider on the styling section is just too good, very nice touch!

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 1, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 1, 2021
@siriwatknp siriwatknp merged commit f5e1da0 into mui:next Sep 1, 2021
@oliviertassinari
Copy link
Member

changed to h2, h3 instead but for which one should be h2, I am not sure.

As far as I know, headers are supposed to be continuous h3 + h2 would break this rule. h2 + h3 sounds OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants