[TablePagination] Re-introduce deprecated onChangePage to ActionsComponent
#27407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
bug 🐛
Details of bundle changes.Comparing: 4fe0df5...4a7bc07 Details of page changes
|
eps1lon
force-pushed
the
fix/TablePagination/deprecation
branch
from
1328d7e to
416742a
Compare
mnajdova
reviewed
Jul 23, 2021
| onChangePage: onChangePageProp, | ||
| onPageChange: onPageChangeProp, | ||
| onChangePage, | ||
| onPageChange, |
There was a problem hiding this comment.
We should make this optional prop too, no? https://github.com/mui-org/material-ui/blob/416742a8fddf03cffba2a68c90b63662bfb5f814/packages/material-ui/src/TablePagination/TablePagination.d.ts#L35
There was a problem hiding this comment.
Why is this relevant to prop destructuring?
There was a problem hiding this comment.
What I meant is that, in order to fix the issue, we need to make both props optional in this component too, as we made them in TablePaginationActions. Currently onPageChange is required.
There was a problem hiding this comment.
What I meant is that, in order to fix the issue
What issue are you referring to? The original issue is fixed and the test suite is green. You're probably not talking about the runtime which is confusing since the conversation is targetted at the .js file.
There was a problem hiding this comment.
@mnajdova I would personally keep the types failing, to give a stronger signal to developers that they need to update their code. But no strong point of view.
There was a problem hiding this comment.
Agree the runtime issue is fixed, I thought that it's good chance to fix the changed interface as well, as it is a breaking change for the typescript users. Here is the discussion around it: #23789 (comment)
There was a problem hiding this comment.
I don't understand how the types are failing. I only have the issue and test suite to go off. If you think there's a problem, please provide a concrete example.
…s.d.ts Co-authored-by: Marija Najdova <mnajdova@gmail.com>
Can't make this truyl type safe since either function has to be declared not both. And what is require depends on the contextual TablePagination usage. Let's just ensure runtime and compile time don't complain about the common use cases.
oliviertassinari
changed the title
onChangePage to ActionsComponentonChangePage to ActionsComponent
eps1lon
changed the title
onChangePage to ActionsComponentonChangePage to ActionsComponent
oliviertassinari
changed the title
onChangePage to ActionsComponentonChangePage to ActionsComponent
eps1lon
changed the title
onChangePage to ActionsComponentonChangePage to ActionsComponent
oliviertassinari
changed the title
onChangePage to ActionsComponentonChangePage to ActionsComponent
|
Awesome, thanks for the fix! Do you have any idea of when this bug fix will be released? The react-admin users keep on reporting the underlying bug, so it seems to be very annoying. |
eps1lon
changed the title
onChangePage to ActionsComponentonChangePage to ActionsComponent
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27192
Verified: https://codesandbox.io/s/awesome-frost-5nxj0