[system] Add missing main entry for styleFunctionSx
#25885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
bug 🐛
oliviertassinari
approved these changes
Apr 22, 2021
There was a problem hiding this comment.
Does it closes #25857?
Before
{
"sideEffects": false,
"module": "./index.js",
"main": "../node/styleFunctionSx/index.js",
"types": "./index.d.ts"
}https://unpkg.com/browse/@material-ui/system@5.0.0-alpha.30/styleFunctionSx/package.json
After
{
"sideEffects": false,
"module": "../esm/styleFunctionSx/index.js",
"main": "./index.js",
"types": "./index.d.ts"
}
To answer my own question, yes. How did you link the PR with the issue? I have never seen this done in the past. I have almost didn't see it.
|
Oh, from here:
First time I see this GitHub feature. I wonder what the others think about it. I don't like how it's easy to miss. "Closes #xxx" seems to make it more obvious, but maybe it's only a matter of habit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should've verified these entries to begin with (happy-path fallacy).
Can't wait to use
exportsfield and get rid of all the aliasing and path shenanigans.Test plan