Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Drawer] Fix classes forwarded to DOM node for docked drawer #25870

Merged
merged 4 commits into from
Apr 22, 2021
Merged

[Drawer] Fix classes forwarded to DOM node for docked drawer #25870

merged 4 commits into from
Apr 22, 2021

Conversation

mnajdova
Copy link
Member

Fixes issue spotted here https://validator.w3.org/nu/?doc=https%3A%2F%2Fnext.material-ui.com%2Fcomponents%2Falert%2F%23main-content#interactive

The classes are being blocked for Root, but forwarded on other slot. However, on this component the Docked slot is used as root, so we need to block them.

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 21, 2021 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against f96c7a0

oliviertassinari
oliviertassinari approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks a bit magical (for somebody that doesn't have the context). Maybe destructuring the classes would be clearer or renaming shouldForwardProp -> rootShouldForwardProp.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: drawer This is the name of the generic UI component, not the React module! labels Apr 21, 2021
@mnajdova
Copy link
Member Author

The fix looks a bit magical (for somebody that doesn't have the context). Maybe destructuring the classes would be clearer or renaming shouldForwardProp -> rootShouldForwardProp.

fair enough, let me rename it

@mnajdova mnajdova merged commit 2ea9dfd into mui:next Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: drawer This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnajdova @mui-pr-bot @oliviertassinari