[SpeedDial] Open/Close synchronous

[eps1lon]

Experiment with leveraging React's batching semantics/event.relatedTarget over setTimeout

[mui-pr-bot]

Details of bundle changes

@material-ui/core: parsed: -0.07% 😍, gzip: -0.06% 😍
@material-ui/lab: parsed: -0.08% 😍, gzip: -0.05% 😍

Generated by 🚫 dangerJS against 571382f

[eps1lon]

Looks good to me but I found another existing bug so automatic coverage might be incomplete. Maybe manual review finds more stress cases

[oliviertassinari]

I recall working on this logic in #17301. Let's see if I can notice a regression with the change

[oliviertassinari]

It looks like we can/should add a new regression test case. The nominal use case of the speed dial doesn't work with the change.

I'm saying nominal because the only environment in which Material Design mentions the component is: mobile. Google used to use it on desktop at some point, but remove them all AFAIK (e.g. Google Inbox which was decommissioned)

On a related note, we can link Material Design to https://material.io/components/buttons-floating-action-button#types-of-transitions in the docs. There are no chips for it. fixed

[oliviertassinari]

For clarity, a failing example:

1. Open https://deploy-preview-25320--material-ui.netlify.app/components/speed-dial/#basic-speed-dial on mobile (e.g. iPhone simulator, a real Android, Chrome mobile simulator)
2. Tap on the FAB to open the speed dial, it won't open.

[eps1lon]

That's odd that focus/blur logic would impact tapping on mobile.

[eps1lon]

For clarity, a failing example:

That's not clarity. The previous comment did not contribute anything to this PR.

[eps1lon]

The SpeedDial is unorthodox regarding it's opening mechanism. We'd have to batch a complete user tap to make this work. Unorthodox regarding that hover and click toggles the open state. It should be either or.

The explainer in code comments is incomplete at the moment and misleading. Will not spend time on it since I don't understand what context triggered that kind of review above. Seems like the component implements behavior that is not publicly documented.

[oliviertassinari]

Seems like the component implements behavior that is not publicly documented.

Do you mean that Google has removed the speed dial from all its product? I personally can't find one where it's still used :/ (For instance, I have checked the 18 installed Google app my phone has).