-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Paper] Migrate to emotion #24397
[Paper] Migrate to emotion #24397
Conversation
povilass
commented
Jan 13, 2021
- I have followed (at least) the PR section of the contributing guide.
@material-ui/core: parsed: +0.21% , gzip: +0.12% |
Demo code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a couple of minor comments :)
For fixing the framer issue, feel free to add the diff --git a/framer/scripts/framerConfig.js b/framer/scripts/framerConfig.js
index fb02f439b6..526d4d294a 100644
--- a/framer/scripts/framerConfig.js
+++ b/framer/scripts/framerConfig.js
@@ -225,6 +225,7 @@ export const componentSettings = {
},
Paper: {
ignoredProps: [
+ 'sx',
// FIXME: `Union`
'variant',
], |
Yes, just look at that and did not get why this is happening with the framer xd. |
Ok, great all seems to be ok now. I think after the release 5.0.0-alpha.23, I will commit AppBar, because I need Paper with emotion or if this will be merged to master. |
In the future if you want to test showcase codesandbox with recent changes, you can open any example on this build, by following the netlify build - it will contain the codesandbox packages for this PR I've created this demo with the recent changes - https://codesandbox.io/s/variants-material-demo-forked-qf81f?file=/demo.js
Sounds great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! This is the first PR from the community for migrating a component to the new styling engine. 🙏 Thanks for your contribution!
Yes I tried netlify in previous issues. |