Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add ClassKeys migration description for Renaming API #22061

Merged
merged 4 commits into from
Aug 5, 2020
Merged

[docs] Add ClassKeys migration description for Renaming API #22061

merged 4 commits into from
Aug 5, 2020
+18 −0

Conversation

kodai3
Copy link
Contributor

@kodai3 kodai3 commented Aug 3, 2020

As @mnajdova pointed out #22053 (review), I think we should document the change of classKeys.

This PR for updating already merged two PRs.
#22015
#22050

@kodai3
Copy link
Contributor Author

kodai3 commented Aug 3, 2020

As working on this, I found anchorOriginBottomLeftCircular is missing in classKeys.

Is this on purpose or just missing?

@mui-pr-bot
Copy link

mui-pr-bot commented Aug 3, 2020 •
edited
Loading

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%
@material-ui/utils: parsed: +Infinity% , gzip: +Infinity%

Details of bundle changes

Generated by 🚫 dangerJS against a8981ad

@mbrookes
Copy link
Member

mbrookes commented Aug 4, 2020

classname or className?

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Aug 4, 2020
@oliviertassinari @kodai3
Update docs/src/pages/guides/migration-v4/migration-v4.md
06e800b 
Co-authored-by: kodai <33568829+kodai3@users.noreply.github.com>
@oliviertassinari oliviertassinari merged commit 574fd61 into mui:next Aug 5, 2020
@hzhz hzhz mentioned this pull request Feb 16, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Apr 13, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Apr 27, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jun 10, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jan 17, 2022
Open
@hzhz hzhz mentioned this pull request Aug 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kodai3 @mui-pr-bot @mbrookes @oliviertassinari