[SvgIcon] Add displayName in react-devtools #21134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 90babbd...f871c76 Details of page changes
|
oliviertassinari
changed the title
eps1lon
approved these changes
May 25, 2020
eps1lon
changed the title
|
@gndplayground Very nice, thanks! |
NMinhNguyen
reviewed
May 25, 2020
| </SvgIcon> | ||
| )), | ||
| const Component = (props, ref) => ( | ||
| <SvgIcon data-mui-test={`${displayName}Icon`} ref={ref} {...props}> |
There was a problem hiding this comment.
Not really related to the diff in this PR, but what do we need memo for exactly? Was it added to prevent unnecessary re-renders or something?
There was a problem hiding this comment.
It's one of the only components that doesn't accept a react element as a prop, so one of the few spots where memo can work on the library. Do we have a benchmark that shows the win on a real-life use case? No.
There was a problem hiding this comment.
It's most likely worse for perf since SvgIcon almost never has an expensive tree on which we want to bail out. But now we have it so somebody might rely on it.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked in the devtool I cannot see Icon display name.
Before
After
Not sure if it related to the PR here facebook/react#17274