-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Export everything from the second level #18306
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8262b1f
[core] Add some missing exports
merceyz 63abd51
[TableCell] Reuse Padding and Size from Table
merceyz 959d738
[core] Export everything
merceyz ca6304f
[Autocomplete] Re-export createFilterOptions
merceyz f0e7461
[lab] Export everything
merceyz 868db55
[styles] Export everything
merceyz 2af8fb4
[Autocomplete] Don't re-export from useAutocomplete
merceyz 51862b2
[core] Remove ModalManager export
merceyz 4149955
Revert "[Autocomplete] Don't re-export from useAutocomplete"
merceyz 2a9e635
[useAutocomplete] Skip exporting createFilterOptions
merceyz bc77b50
fix CI
oliviertassinari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,32 @@ | ||
export { default as Autocomplete } from './Autocomplete'; | ||
export * from './Autocomplete'; | ||
|
||
export { default as Rating } from './Rating'; | ||
export * from './Rating'; | ||
|
||
export { default as Skeleton } from './Skeleton'; | ||
export * from './Skeleton'; | ||
|
||
export { default as SpeedDial } from './SpeedDial'; | ||
export * from './SpeedDial'; | ||
|
||
export { default as SpeedDialAction } from './SpeedDialAction'; | ||
export * from './SpeedDialAction'; | ||
|
||
export { default as SpeedDialIcon } from './SpeedDialIcon'; | ||
export * from './SpeedDialIcon'; | ||
|
||
export { default as ToggleButton } from './ToggleButton'; | ||
export * from './ToggleButton'; | ||
|
||
export { default as ToggleButtonGroup } from './ToggleButtonGroup'; | ||
export { default as TreeView } from './TreeView'; | ||
export * from './ToggleButtonGroup'; | ||
|
||
export { default as TreeItem } from './TreeItem'; | ||
export { default as useAutocomplete, createFilterOptions } from './useAutocomplete'; | ||
export * from './TreeItem'; | ||
|
||
export { default as TreeView } from './TreeView'; | ||
export * from './TreeView'; | ||
|
||
export { default as useAutocomplete } from './useAutocomplete'; | ||
export * from './useAutocomplete'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,33 @@ | ||
/* eslint-disable import/export */ | ||
export { default as Autocomplete } from './Autocomplete'; | ||
export * from './Autocomplete'; | ||
|
||
export { default as Rating } from './Rating'; | ||
export * from './Rating'; | ||
|
||
export { default as Skeleton } from './Skeleton'; | ||
export * from './Skeleton'; | ||
|
||
export { default as SpeedDial } from './SpeedDial'; | ||
export * from './SpeedDial'; | ||
|
||
export { default as SpeedDialAction } from './SpeedDialAction'; | ||
export * from './SpeedDialAction'; | ||
|
||
export { default as SpeedDialIcon } from './SpeedDialIcon'; | ||
export * from './SpeedDialIcon'; | ||
|
||
export { default as ToggleButton } from './ToggleButton'; | ||
export * from './ToggleButton'; | ||
|
||
export { default as ToggleButtonGroup } from './ToggleButtonGroup'; | ||
export * from './ToggleButtonGroup'; | ||
|
||
export { default as TreeItem } from './TreeItem'; | ||
export * from './TreeItem'; | ||
|
||
export { default as TreeView } from './TreeView'; | ||
export { default as useAutocomplete, createFilterOptions } from './useAutocomplete'; | ||
export * from './TreeView'; | ||
|
||
// createFilterOptions is exported from Autocomplete | ||
export { default as useAutocomplete } from './useAutocomplete'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,40 @@ | ||
export { default as createGenerateClassName } from './createGenerateClassName'; | ||
export * from './createGenerateClassName'; | ||
|
||
export { default as createStyles } from './createStyles'; | ||
export * from './createStyles'; | ||
|
||
export { default as getThemeProps } from './getThemeProps'; | ||
export * from './getThemeProps'; | ||
|
||
export { default as jssPreset } from './jssPreset'; | ||
export * from './jssPreset'; | ||
|
||
export { default as makeStyles } from './makeStyles'; | ||
export * from './makeStyles'; | ||
|
||
export { default as mergeClasses } from './mergeClasses'; | ||
export * from './mergeClasses'; | ||
|
||
export { default as ServerStyleSheets } from './ServerStyleSheets'; | ||
export * from './ServerStyleSheets'; | ||
|
||
export { default as styled } from './styled'; | ||
export * from './styled'; | ||
|
||
export { default as StylesProvider } from './StylesProvider'; | ||
export * from './StylesProvider'; | ||
|
||
export { default as ThemeProvider } from './ThemeProvider'; | ||
export { default as useTheme } from '@material-ui/styles/useTheme'; | ||
export { default as withStyles, CSSProperties, StyleRules, WithStyles } from './withStyles'; | ||
export { default as withTheme, WithTheme, withThemeCreator } from './withTheme'; | ||
export * from './ThemeProvider'; | ||
|
||
export { default as useTheme } from './useTheme'; | ||
export * from './useTheme'; | ||
|
||
export { default as withStyles } from './withStyles'; | ||
export * from './withStyles'; | ||
|
||
export { default as withTheme } from './withTheme'; | ||
export * from './withTheme'; | ||
|
||
export { DefaultTheme } from './defaultTheme'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oliviertassinari What happened here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously,
isWidthUp
wasn't exported from the barrel index.js. With the latest changes, imports can be changed. However, the codemod doesn't support the following case well:It needs two runs to handle it correctly. This breaks the idempotent assertion.
I haven't found how to fix the 2 runs issue. Instead, I have changed the import syntax so the codemod test can be idempotent (equivalent to ignoring the problem).