[RadioGroup] Support uncontrolled mode #13929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
the
component: radio
|
@rfbotto We just miss the unit test, it would be too easy otherwise :). |
eps1lon
previously requested changes
Dec 18, 2018
|
@eps1lon Thank you for the feedback! 👍 Will integrate it as soon as possible. |
oliviertassinari
dismissed
eps1lon’s stale review
I believe your feedback have been addressed. I'm happy with the pull request. I'm adding the "good for merge" tag. Feel free to merge it.
oliviertassinari
approved these changes
Dec 19, 2018
|
@rfbotto You have been doing some great pull-requests over the last few weeks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13915