[core] 100% remove the prop types #13859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
prop-types-unsafe-wrap
branch
2 times, most recently
from
a134072
to
aa39e10
Compare
oliviertassinari
force-pushed
the
prop-types-unsafe-wrap
branch
from
aa39e10
to
79b4b59
Compare
eps1lon
reviewed
Dec 14, 2018
| @@ -88,7 +88,9 @@ StylesProvider.propTypes = { | |||
| sheetsRegistry: PropTypes.object, | |||
| }; | |||
|
|
|||
| StylesProvider.propTypes = exactProp(StylesProvider.propTypes); | |||
| if (process.env.NODE_ENV !== 'production') { | |||
There was a problem hiding this comment.
@oliviertassinari Does the plugin currently not support this or why is manually wrapping required in some places?
There was a problem hiding this comment.
The plugin doesn't support it.
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs of the
unsafe-wrapoption can be found in https://github.com/oliviertassinari/babel-plugin-transform-react-remove-prop-types#options.Now, this has one implication. People can't access nested attributes of our prop types.
Doing
Button.propTypesis OK butButton.propTypes.componentis KO if they don't use the Babel plugin too. CRA has the same behavior, so it's not really a controversial choice. But I have added the v3.7.0 milestone just in case (no patch).