Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ExpansionPanelSummary] Add disableRippleIconButton property to ExpansionPanelSummary #10638

Closed
wants to merge 2 commits into from
Closed

[ExpansionPanelSummary] Add disableRippleIconButton property to ExpansionPanelSummary #10638

wants to merge 2 commits into from

Conversation

abnersajr
Copy link
Contributor

Actually, We can't disable the ripple effect in the <IconButton /> on <ExpansionPanelSummary />
By default, it's already supported, but We don't pass in any way this props.
This PR allows us to control the effect.

@oliviertassinari oliviertassinari added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Mar 13, 2018
@abnersajr
Copy link
Contributor Author

@oliviertassinari thank you for assign this.
I tried so hard to see how to disable that effect, but I couldn't figure out how to do that without these changes.
For sure, name suggestions and editions are appreciated.

@oliviertassinari
Copy link
Member

@abnersajr We can't possibly allow people to cherry-pick each property individually.

@abnersajr
Copy link
Contributor Author

abnersajr commented Mar 13, 2018

@oliviertassinari so how I can disable this effect without this change? Any suggestion?
I understand that we cant allow people to cherry-pick it, but is the third time that I need to disable the ripple animation, the other 2 times I could do that. But without this PR I can't.

@oliviertassinari
Copy link
Member

so how I can disable this effect without this change? Any suggestion?

@abnersajr Good question. I will soon come back to you with a definitive answer. We need to clear this problem before releasing stable v1. It's not the only occurrence of such problem.

@oliviertassinari
Copy link
Member

What about #10671?

@abnersajr
Copy link
Contributor Author

Closing this PR in fact of #10671

@abnersajr abnersajr closed this Mar 21, 2018
@abnersajr abnersajr deleted the chore/add-disableRipple-IconButton branch March 21, 2018 02:29
@oliviertassinari oliviertassinari mentioned this pull request Apr 22, 2018
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants