Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update grammar/capitalization on the landing page for the docs site #9053

Closed
m2mathew opened this issue Nov 8, 2017 · 5 comments
Closed
Labels
docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@m2mathew
Copy link
Member

m2mathew commented Nov 8, 2017

image

This should read:

  • "A Set of React Components that Implements Google's Material Design"
    • Read it without the prepositional phrase "of React Components" to hear it better

Maybe the capitalization can be adjusted, as well. It is not a title, so using a normal sentence capitalization scheme would be preferable to me.

  • "A set of React components that implements Google's Material Design"
@m2mathew m2mathew added docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process. labels Nov 8, 2017
@leMaik
Copy link
Member

leMaik commented Nov 8, 2017

But it's not the set that implements Material Design, it's the components that implement it, so there is no "s" required. 🤔

That said, the title case should be changed, it looks weird…

@m2mathew
Copy link
Member Author

m2mathew commented Nov 8, 2017

The subject of the sentence is the word set. If we want to reword the sentence, that is fine, but it is incorrect as written.

@mbrookes
Copy link
Member

mbrookes commented Nov 8, 2017

Even though it sounds odd, I believe @m2mathew is technically correct on the grammar.

I was going to suggest dropping "A set" to satisfy leMaik, so:

"React components that implement Google's Material Design"

then noticed @oliviertassinari had added the legacy tag, so went to see what we had on v1-beta. Lo and behold (!):

"React Components that Implement Google's Material Design."

(We still need to fix the casing there.)

@m2mathew
Copy link
Member Author

m2mathew commented Nov 9, 2017

I will update the legacy real quick. That @oliviertassinari...so smart!

@oliviertassinari
Copy link
Member

v0.x and v1.x have been fixed :)

the-noob pushed a commit to the-noob/material-ui that referenced this issue Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Development

No branches or pull requests

4 participants