Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextField] Wrong disabled color in Safari #23332

Closed
mtr1990 opened this issue Oct 31, 2020 · 8 comments · Fixed by #23375
Closed

[TextField] Wrong disabled color in Safari #23332

mtr1990 opened this issue Oct 31, 2020 · 8 comments · Fixed by #23375
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! external dependency Blocked by external dependency, we can’t do anything about it good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@mtr1990
Copy link

mtr1990 commented Oct 31, 2020

In my case

téléchargement

How to fix it?

@mtr1990 mtr1990 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 31, 2020
@eps1lon
Copy link
Member

eps1lon commented Oct 31, 2020

It doesn't look like this bug report has enough info for one of us to reproduce it.

Please provide a CodeSandbox (https://material-ui.com/r/issue-template), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem.

Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve

@eps1lon eps1lon added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 31, 2020
@mtr1990
Copy link
Author

mtr1990 commented Oct 31, 2020

Hi @eps1lon I'm sorry,

This is link :
https://codesandbox.io/s/material-demo-forked-e8g4f?file=/demo.js

Please compare in safari and chrome, Thanks!

@oliviertassinari oliviertassinari added component: text field This is the name of the generic UI component, not the React module! and removed status: waiting for author Issue with insufficient information labels Oct 31, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 31, 2020

We would need to apply this diff to fix the opacity on Safari.

diff --git a/packages/material-ui/src/InputBase/InputBase.js b/packages/material-ui/src/InputBase/InputBase.js
index 381f3a53d1..2221a81fb2 100644
--- a/packages/material-ui/src/InputBase/InputBase.js
+++ b/packages/material-ui/src/InputBase/InputBase.js
@@ -50,6 +50,7 @@ export const styles = (theme) => {
       '&$disabled': {
         color: theme.palette.text.disabled,
         cursor: 'default',
+        WebkitTextFillColor: theme.palette.text.disabled, // Fix opacity Safari bug
       },
     },
     /* Styles applied to the root element if the component is a descendant of `FormControl`. */

However, it would also force all the customization to adapt. So the question is, will most developers want to know about this issue and update their styles accordingly?

Related: jgthms/bulma#2355, carbon-design-system/carbon#6673.

@oliviertassinari oliviertassinari added the external dependency Blocked by external dependency, we can’t do anything about it label Oct 31, 2020
@oliviertassinari oliviertassinari changed the title Text Field color disabled not correct in safari [TextField] Wrong disabled color in Safari Oct 31, 2020
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Oct 31, 2020
@mtr1990
Copy link
Author

mtr1990 commented Oct 31, 2020

Yes, I think this is necessary,
Thanks for help me, It's woking!

@mtr1990 mtr1990 closed this as completed Oct 31, 2020
@oliviertassinari oliviertassinari added the good first issue Great for first contributions. Enable to learn the contribution process. label Oct 31, 2020
@oliviertassinari
Copy link
Member

Considering it's using the design token from the theme, I think that we can move forward, it should be fine.

@morijenab
Copy link
Contributor

can I take it?

@oliviertassinari
Copy link
Member

@mtr1990 would have priority as it's thanks to him that we would be fixing this bug. If he's not interested, definitely.

@oliviertassinari
Copy link
Member

@Morteza-Jenabzadeh Feel free to move forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! external dependency Blocked by external dependency, we can’t do anything about it good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants