-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TextField] Wrong disabled color in Safari #23332
Comments
It doesn't look like this bug report has enough info for one of us to reproduce it. Please provide a CodeSandbox (https://material-ui.com/r/issue-template), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem. Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve |
Hi @eps1lon I'm sorry, This is link : Please compare in safari and chrome, Thanks! |
We would need to apply this diff to fix the opacity on Safari. diff --git a/packages/material-ui/src/InputBase/InputBase.js b/packages/material-ui/src/InputBase/InputBase.js
index 381f3a53d1..2221a81fb2 100644
--- a/packages/material-ui/src/InputBase/InputBase.js
+++ b/packages/material-ui/src/InputBase/InputBase.js
@@ -50,6 +50,7 @@ export const styles = (theme) => {
'&$disabled': {
color: theme.palette.text.disabled,
cursor: 'default',
+ WebkitTextFillColor: theme.palette.text.disabled, // Fix opacity Safari bug
},
},
/* Styles applied to the root element if the component is a descendant of `FormControl`. */ However, it would also force all the customization to adapt. So the question is, will most developers want to know about this issue and update their styles accordingly? Related: jgthms/bulma#2355, carbon-design-system/carbon#6673. |
Yes, I think this is necessary, |
Considering it's using the design token from the theme, I think that we can move forward, it should be fine. |
can I take it? |
@mtr1990 would have priority as it's thanks to him that we would be fixing this bug. If he's not interested, definitely. |
@Morteza-Jenabzadeh Feel free to move forward |
In my case
How to fix it?
The text was updated successfully, but these errors were encountered: