[SpeedDial] Speed dial action binding enter event

[basicfu]

When I click on speedDialAction onClick event after,speedDialAction close after,Still triggered onClick event
repeat url: https://material-ui.com/lab/speed-dial/

[mbrookes]

@basicfu Sorry, I can't understand what you're saying. Please use the issue template, and provide a reproducible example (edit the docs example in CodeSandbox)

[basicfu]

I'm sorry, my English is very poor
The official demo can reproducible: https://material-ui.com/lab/speed-dial/
speedDialAction After closing the keyboard can still onClick

[basicfu]

@mbrookes
repeat steps:

• onClick addIcon
• onClick copyIcon
• the mouse left copyIcon
• press enter
• press enter
• press enter
  problem: Enter can trigger handleMsg event,When I click on a blank place at will,Enter events disappear
  demo: https://codesandbox.io/s/j2m7wrjjm5

[basicfu]

@mbrookes Can you help me?

[heregoesnoth]

@mbrookes the problem is: when you click in some option (in this case, copyIcon), you can press enter that will trigger the action again, but when mouve leave and the options are close, you still can trigger the action.

@basicfu workaround

  handleMsg = () => {
    if (this.state.open) {
      this.setState(state => ({
        msg: state.msg + "close.."
      }));
    console.log("msg...");
    }
  };

[basicfu]

@lucasgms16 Thank you very much, this will solve the problem,When my keyboard events in the parent layer when listening,I need to deal with the state in the parent layer
@mbrookes I want to know,when mouse leave and the options are close,press enter whether can also trigger action

[mbrookes]

@lucasgms16 Thanks! Do you want to work on a fix?

[heregoesnoth]

@mbrookes sure!

[eps1lon]

Did some quick testing and while it is trivial to put the focus back on the dial it is not viable to use this with our current demo setup because onFocus will be triggered. I think we should provide a full a11y solution and this is quite hard if users can control the open state.

My preferred solution would be to have a good menu implementation that considers all a11y concerns and then use this in SpeedDial and Menu. Right now those concerns are not in one place. What do you think @mbrookes?

[mbrookes]

Makes sense in principal to share with menu. Controlled components are the preferred approach in Material-UI though.