Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FormControlLabel] Add labelPlacement?: 'top' | 'bottom' #12063

Closed
serle opened this issue Jul 5, 2018 · 5 comments
Closed

[FormControlLabel] Add labelPlacement?: 'top' | 'bottom' #12063

serle opened this issue Jul 5, 2018 · 5 comments
Labels
good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request

Comments

@serle
Copy link

serle commented Jul 5, 2018

Currently the FormControlLabel only allows the label to appear on the right of the Control (Switch, Radio, Checkbox). It would be helpful to provide a property to position the Label on the Top, Right and Left.
@oliviertassinari oliviertassinari added the duplicate This issue or pull request already exists label Jul 5, 2018
@oliviertassinari
Copy link
Member

I'm closing as a duplicate of #11618

@JulienMalige
Copy link
Contributor

@oliviertassinari I don't think it's really a duplicate. I'm looking to add a label top on a Checkbox, and it seems not possible.

ex:
image

@oliviertassinari oliviertassinari added new feature New feature or request and removed duplicate This issue or pull request already exists labels Nov 1, 2018
@oliviertassinari oliviertassinari changed the title Feature Request: FormControlLabel - allow positioning Left, Right, Top [FormControlLabel] Add labelPlacement?: 'top' | 'bottom' Nov 1, 2018
@oliviertassinari
Copy link
Member

@JulienMalige Sure, we can add thetop and bottom variants. Thank you for raising 👍 .

@oliviertassinari oliviertassinari added the good first issue Great for first contributions. Enable to learn the contribution process. label Nov 1, 2018
@serle
Copy link
Author

serle commented Nov 1, 2018 •
edited
Loading

I'm assuming that the checkbox and label would be center aligned (in the case of a top or bottom label) and certainly in the case of a top label it should be aligned "vertically" with other control labels so that if one places multiple controls on a row, the labels all align.

@oliviertassinari
Copy link
Member

@serle Yes, I think too.

@JulienMalige JulienMalige mentioned this issue Nov 3, 2018
Merged
1 task
oliviertassinari pushed a commit that referenced this issue Nov 4, 2018
@JulienMalige @oliviertassinari
[FormControlLabel] Add top and bottom labelPlacement property varia…
0c8297d 
…nts (#13499)

* [FormControlLabel] Top and Bottom labelPlacement prop (#12063)

* dedicate a demo to the labelPlacement property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oliviertassinari @JulienMalige @serle