Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress/Spinner not working correctly when React render heavy page #12061

Closed
2 tasks done
HRK44 opened this issue Jul 5, 2018 · 4 comments · Fixed by #12062
Closed
2 tasks done

Progress/Spinner not working correctly when React render heavy page #12061

HRK44 opened this issue Jul 5, 2018 · 4 comments · Fixed by #12062
Labels
docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@HRK44
Copy link
Contributor

HRK44 commented Jul 5, 2018

  • This is a v1.x issue (v0.x is no longer maintained).
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

The progress should show correctly (spinning, loading, etc...).

Current Behavior

The progress component is not spinning/loading and stays frozen or is very thin (does not render well) when it's a circularprogress.

This is what a circularprogress looks like (size 50) :
screenshot from 2018-07-05 10-30-07

Steps to Reproduce (for bugs)

  1. Create a react page that takes some time to render (due to lof of components)
  2. Set initial state in the constructor this.state.rendering = true
  3. Set state in componentDidMount or in componentDidUpdate to this.state.rendering = false
  4. Display conditionally the progress in the render() function base on this.state.rendering

Context

Your Environment

Tech Version
Material-UI v1.2.1
React 16.4
browser Chrome Version 67.0.3396.99 (Official Build) (64-bit)
@oliviertassinari oliviertassinari added the duplicate This issue or pull request already exists label Jul 5, 2018
@oliviertassinari
Copy link
Member

I'm closing as a duplicate of #10327

@HRK44
Copy link
Contributor Author

HRK44 commented Jul 5, 2018

Since this is a limitation, maybe we can add some notes in the doc to notify people?

@oliviertassinari
Copy link
Member

@HRK44 Yes, we could! Do you want to work on it? :)

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process. and removed duplicate This issue or pull request already exists labels Jul 5, 2018
HRK44 added a commit to HRK44/material-ui that referenced this issue Jul 5, 2018
@HRK44
Copy link
Contributor Author

HRK44 commented Jul 5, 2018

On a side note, there is no api folder under docs/src/pages/, is it normal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants