[core] Rely on immutable ref when possible (#40831)

mui · Jan 29, 2024 · 4ee5046 · 4ee5046
1 parent 147db41
commit 4ee5046
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/packages/mui-base/src/unstable_useModal/useModal.ts b/packages/mui-base/src/unstable_useModal/useModal.ts
@@ -54,7 +54,7 @@ export function useModal(parameters: UseModalParameters): UseModalReturnValue {
 
   // @ts-ignore internal logic
   const modal = React.useRef<{ modalRef: HTMLDivElement; mount: HTMLElement }>({});
-  const mountNodeRef = React.useRef<null | HTMLElement>(null);
+  const mountNodeRef = React.useRef<HTMLElement | null>(null);
   const modalRef = React.useRef<HTMLDivElement>(null);
   const handleRef = useForkRef(modalRef, rootRef);
   const [exited, setExited] = React.useState(!open);

diff --git a/packages/mui-material-next/src/Menu/Menu.tsx b/packages/mui-material-next/src/Menu/Menu.tsx
@@ -98,7 +98,7 @@ const MenuInner = React.forwardRef(function Menu(inProps, ref) {
   const theme = useTheme();
   const isRtl = theme.direction === 'rtl';
 
-  const listRef = React.useRef<HTMLElement | null>(null);
+  const listRef = React.useRef<HTMLElement>(null);
 
   // TODO v6: Handle the rest of the props from the MenuListProps prop
   const {

diff --git a/packages/mui-material-next/src/MenuItem/MenuItem.tsx b/packages/mui-material-next/src/MenuItem/MenuItem.tsx
@@ -183,7 +183,7 @@ const MenuItem = React.forwardRef(function MenuItem<RootComponentType extends Re
     [context.dense, dense, disableGutters],
   );
 
-  const menuItemRef = React.useRef<HTMLElement | null>(null);
+  const menuItemRef = React.useRef<HTMLElement>(null);
   const handleRef = useForkRef(menuItemRef, ref);
 
   const { getRootProps, disabled, focusVisible, highlighted } = useMenuItem({

diff --git a/packages/mui-material-next/src/Option/Option.tsx b/packages/mui-material-next/src/Option/Option.tsx
@@ -180,7 +180,7 @@ const Option = React.forwardRef(function Option<RootComponentType extends React.
     [context.dense, dense, disableGutters],
   );
 
-  const optionRef = React.useRef<HTMLElement | null>(null);
+  const optionRef = React.useRef<HTMLElement>(null);
   const handleRef = useForkRef(optionRef, ref);
 
   const { getRootProps, disabled, focusVisible, highlighted } = useMenuItem({