-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date-io v2: Uncaught RangeError: Format string contains an unescaped latin alphabet character n
#1440
Comments
For others struggling: if you installed
For now, downgrade to |
n
n
n
Updated the docs. Also pinning this issue to make it easier to resolve the problem for v3 users |
BTW, |
They do it! |
Would it perhaps be possible to have the proper versions of the @date-io libaries listed as dependencies in this project instead of referring to a note in an installation guide? Tbh I think it's a bit odd we have to manually manage the @date-io dependencies because @material-ui/pickers doesn't specify the versions it requires (and so we now have two outdated dependencies in our projects which need to be pinned to the 1.x release for the time being). |
@dmtrKovalenko Since recently, we can leverage the optional peer dependencies, e.g. mui/material-ui#17211, that, I believe would warn if the version is not correct. |
@dmtrKovalenko Alternatively, what do you think of changing the npm tags (to have latest point to v1 and next point to v2), until we complete the upgrade of the picker components? |
Agree, but the main idea is that date-io is also used by other packages. We should not depend on date-io version. Also there is a specific version of @date-ui/core that points picker to use ‘1.3.11’ and do the peer deps validation. |
Forgive my ignorance 😊 but wouldn't it be easier to be able to specify the utils library you want to use, instead of providing it through dependency injection? For example: |
@rvanmil no, because it will lead to additional bundlesize and utils are directly importing |
@dmtrKovalenko Nice, so we are good.
On a side note, I have noticed two potential opportunities:
|
Very weird shit, I have to admit. |
👀 |
Had the same problem, but I had access to this site |
Dislike! |
I feel bad that I missed the note they left on their docs, it was even in bold LOL |
How did you guys get it to work? |
Is there any plan to fix this? It was reported on 5th of January and i am still getting this error. That's more than 2 months for something that prevents me from keeping my libraries up to date. |
Sorry guys, but your stuff is not enterprise ready. I will have to look for alternatives. |
I don't understand what paths developers are following to end-up in this configuration. @StefanJelner What step did you took to reproduce this problem? @dmtrKovalenko Maybe we should circle back to #1440 (comment). There is a high number of upvotes (70) in a small time frame (3 months). I understand that you consider |
@oliviertassinari we can easy make an additional release 3.2.11 to support date-fns v2. BUT this update is also must be major, so it will be |
Agree, let's try to gain more feedback from users. I don't understand how the issue could have had 70 upvotes. |
RangeError: Format string contains an unescaped latin alphabet character I got the same error while trying to use @material-ui/pickers |
@Olaide-EO Do you have a reproduction? |
@Olaide-EO try install |
@nikosantis @lucasgabardo How did you end-up with this error? |
By the way
for cloning the project, it seems that @material-ui/pickers.git does not
work but @material-ui-pickers.git seems to work
Le mer. 25 mars 2020 à 15:50, Olivier Tassinari <notifications@github.com>
a écrit :
… @nikosantis <https://github.com/nikosantis> @lucasgabardo
<https://github.com/lucasgabardo> How did you end-up with this error?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1440 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACAMOOCH7R4WZVQUFUYASMTRJIK47ANCNFSM4KC3Z66A>
.
|
give this man a cookie |
RTFM Jesus... The release page of
Keep posting "same here", "+1" contributes NOTHING. |
I don't understand too. Nowadays people just don't read... |
Perhaps this is obvious to everybody but me, but just so I'm clear... There's a v4 of material-ui-pickers that's in the works? And that will resolve this issue? Is there a timeline for the release of v4? |
@bmueller-sykes v3 works, v4 works. |
wait...what? @date-io/2.x works with @material-ui/pickers 3.2.10? I'm confused. I thought that expressly doesn't work. Am I being dense? |
@bmueller-sykes Why do you want to use date-io v2 with pickers v3? |
@oliviertassinari Sorry, now I'm really confused. I use momentJS as my date library in my app overall. In my App.tsx file, I set up the pickers provider like this:
My relevant libs are:
So all I'm trying to do is keep all the libraries up to date. I have a feeling that you're going to tell me I shouldn't be using |
@bmueller-sykes Interesting! The good news is that the owner of date-io is the main author on the pickers, you are already up to date. |
I can't tell if you're making fun of me or not. |
Closing issue, cause it was fixed in v4-alpha. If you are using v3, please lock version of date-io to 1.x |
@bmueller-sykes I wasn't making fun of anyone. I want to reassure the developers that try to upgrade: it's not needed, there is nothing to gain, let's be patient :). |
The
@date-io
library release a new version v2 that's break this module.Please update docs and require install only version 1.X from
@date-io
in the meantime.The text was updated successfully, but these errors were encountered: