Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Adjust conformance tests to support portals #266

Merged
merged 1 commit into from
Apr 4, 2024
Merged

[core] Adjust conformance tests to support portals #266

merged 1 commit into from
Apr 4, 2024

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented Apr 4, 2024

Taken from #186 into this individual PR.

@atomiks atomiks added the core Infrastructure work going on behind the scenes label Apr 4, 2024
michaldudak
michaldudak approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had exactly the same problem with the Tabs PR and ended up with a slightly different implementation, but this one is OK as well.

@atomiks atomiks merged commit 526c484 into mui:master Apr 4, 2024
16 of 17 checks passed
@atomiks atomiks deleted the chore/portals branch April 4, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atomiks @michaldudak