Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[useAnchorPositioning] Ensure keepMounted is a private param #1410

Merged
merged 2 commits into from
Feb 5, 2025
Merged

[useAnchorPositioning] Ensure keepMounted is a private param #1410

merged 2 commits into from
Feb 5, 2025

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented Feb 4, 2025

keepMounted should only exist on Portal parts - Positioner parts were inheriting it incorrectly as a type from useAnchorPositioning.SharedParameters

@atomiks atomiks added core Infrastructure work going on behind the scenes component: select This is the name of the generic UI component, not the React module! component: menu This is the name of the generic UI component, not the React module! component: tooltip This is the name of the generic UI component, not the React module! component: popover The React component. component: preview card The React component. labels Feb 4, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 4, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 6afaa9b
🔍 Latest deploy log https://app.netlify.com/sites/base-ui/deploys/67a1aca9199e17000844e1c4
😎 Deploy Preview https://deploy-preview-1410--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@atomiks atomiks merged commit 83fe8ff into mui:master Feb 5, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

Assignees
No one assigned
Labels
component: menu This is the name of the generic UI component, not the React module! component: popover The React component. component: preview card The React component. component: select This is the name of the generic UI component, not the React module! component: tooltip This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atomiks @michaldudak