[Menu] Fix openOnHover issues
#1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomiks
added
the
component: menu
Netlify deploy preview |
atomiks
commented
Dec 20, 2024
github-actions
bot
added
the
PR: out-of-date
atomiks
force-pushed
the
fix/menu-open-on-hover
branch
from
e753d95 to
3d9ea80
Compare
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
PR: out-of-date
colmtuite
approved these changes
Jan 7, 2025
michaldudak
reviewed
Jan 7, 2025
| @@ -18,6 +18,10 @@ | |||
| "data-closed": { | |||
| "description": "Present when the menu is closed." | |||
| }, | |||
| "data-instant": { | |||
| "description": "Indicates the instant type of the menu popup.", | |||
There was a problem hiding this comment.
TBH this description doesn't help much to understand what this attribute is for.
There was a problem hiding this comment.
Yep, agreed. The one for Popover is the same but I can update both of them.
github-actions
bot
added
the
PR: out-of-date
atomiks
force-pushed
the
fix/menu-open-on-hover
branch
from
9de2385 to
d12cefb
Compare
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1180
Includes
data-instantstyle hook forMenu