[Dialog] Fix nesting different kinds of dialogs #1166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
added
bug 🐛
mj12albert
changed the title
mj12albert
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
Netlify deploy preview |
|
|
||
| const dialogRoot = useDialogRoot({ | ||
| open, | ||
| defaultOpen, | ||
| onOpenChange, | ||
| modal: true, | ||
| dismissible: false, | ||
| onNestedDialogClose: parentDialogRootContext?.onNestedDialogClose, | ||
| onNestedDialogOpen: parentDialogRootContext?.onNestedDialogOpen, | ||
| onNestedDialogClose: parentContext?.onNestedDialogClose, |
There was a problem hiding this comment.
Wouldn't it be cleaner to have a shared context for the element that are shared across the various dialog types?
Or are we confident that we won't have another type of dialog (not sure if a drawer falls in the category) that we will have to remember to add here?
There was a problem hiding this comment.
Yes, I started working on this coincidently, let me open a PR. @mj12albert please assign an issue to you if you plan to work on it to avoid duplicated work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1165