Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump karma-webpack to ^5.0.1 #104

Merged
merged 4 commits into from
May 7, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 27, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
karma-webpack ^5.0.0 -> ^5.0.1 age adoption passing confidence

Release Notes

webpack-contrib/karma-webpack (karma-webpack)

v5.0.1

Compare Source

Fixes
  • security fixes

Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Update of dependencies label Feb 27, 2024
Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit df75e66
🔍 Latest deploy log https://app.netlify.com/sites/base-ui/deploys/65de0af3a0348f000884cf1d
😎 Deploy Preview https://deploy-preview-104--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

argos-ci bot commented Feb 27, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Waiting for the first build to start…

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 27, 2024
@renovate renovate bot force-pushed the renovate/karma-webpack-5.x branch from df75e66 to efcd34b Compare February 27, 2024 21:06
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Feb 27, 2024
@renovate renovate bot force-pushed the renovate/karma-webpack-5.x branch from efcd34b to 3c03f7a Compare February 27, 2024 22:02
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 27, 2024
@michaldudak
Copy link
Member

Similarly to mui/material-ui#40929, TextareaAutosize tests started to fail after this update.

Copy link
Contributor Author

renovate bot commented Feb 27, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 18, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 25, 2024
@michaldudak
Copy link
Member

@ZeeshanTamboli, I was hoping #189 would fix this PR, but it doesn't seem so. Would you like to take a look at this since you already have the context of TextareaAutosize?
It's not urgent, though.

@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented May 5, 2024

@michaldudak Using requestAnimationFrame in production, as indicated in the code comment, resolves the issue. However, I'm unclear why this resolves the issue now and why it failed previously. Additionally, I'm unsure what changes between versions 5.0.0 and 5.0.1 triggered this browser error.

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
I also don't know exactly what changes in 5.0.1 trigger this. This release was mostly about bumping the dependencies, so it could be any of the transitive deps causing this issue.
I've noticed that now karma tests behave more correctly (for example, they now fail when Popper's anchor is not added to the document), and this leads me to believe there were improvements introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants