Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[number field] Disable focus on mobile #224

Closed
oliviertassinari opened this issue Mar 22, 2024 · 2 comments · Fixed by #186
Closed

[number field] Disable focus on mobile #224

oliviertassinari opened this issue Mar 22, 2024 · 2 comments · Fixed by #186
Labels
bug 🐛 Something doesn't work component: number field This is the name of the generic UI component, not the React module!

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 22, 2024

Steps to reproduce

https://mui.com/base-ui/react-number-input/#customization

Screen.Recording.2024-03-22.at.01.32.41.mov

Current behavior

The input is focused on mobile, so the virtual keyboard triggers

Expected behavior

No input focus on mobile when using the control.

Context

See https://www.notion.so/mui-org/core-Input-Number-component-364825a7bec94381809ac11ff05b4cc0. For eample https://react-spectrum.adobe.com/blog/how-we-internationalized-our-numberfield.html looks correct to me. Focus on desktop, no focus on mobile.

Your environment

@mui/base@5.0.0-beta.36

Search keywords: focus

@oliviertassinari oliviertassinari added status: waiting for maintainer These issues haven't been looked at yet by a maintainer component: number field This is the name of the generic UI component, not the React module! bug 🐛 Something doesn't work labels Mar 22, 2024
@colmtuite
Copy link
Contributor

Closing this as it's not an issue on our new implementation which should be merged end of next week.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Mar 22, 2024

@colmtuite I updated the PR that fixes this bug (#186) to include "Closes #224", this is for clarity, and to automatically close the issue once merged. We normally close issues only once HEAD is fixed (master branch today). This is because a PR might get abandoned, split in chunks, etc. It's also a convention between open source projects.

@oliviertassinari oliviertassinari removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: number field This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants