Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when single line comment is ended by block comment suffix #14

Merged
merged 2 commits into from
Mar 25, 2022

Conversation

stirante
Copy link
Contributor

While using the library I encountered an issue, where single line comment can be ended with */.
Example:

{
  // I commented a glob pattern like this "**/*"
  "test" : "Hello"
}

The error I got was invalid character '*' looking for beginning of value.

I added a simple check to not try and end the comment with */ if the comment is single line.

@muhammadmuzzammil1998
Copy link
Owner

Looks great!

Thanks for the PR.

Will merge it soon.

@muhammadmuzzammil1998 muhammadmuzzammil1998 merged commit a626a9b into muhammadmuzzammil1998:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants