use newVirtualThreadPerTaskExecutor

muhammad-salem · Jan 20, 2025 · 957fb9b · 957fb9b
1 parent 767e38a
commit 957fb9b
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 10 deletions.
diff --git a/cli-client/src/main/java/org/ariia/internal/JavaHttpClient.java b/cli-client/src/main/java/org/ariia/internal/JavaHttpClient.java
@@ -31,11 +31,7 @@ public JavaHttpClient(Proxy proxy, String username, char[] password, boolean tru
         var builder = HttpClient.newBuilder()
                 .followRedirects(Redirect.ALWAYS)
                 .connectTimeout(Duration.ofSeconds(20))
-                .proxy(new JavaProxySelector(proxy))
-//			        .proxy(ProxySelector.of( (InetSocketAddress) proxy.address() ))
-//			        .authenticator(Authenticator.getDefault())
-//			        .executor(Executors.newCachedThreadPool())
-                ;
+                .proxy(new JavaProxySelector(proxy));
         if (!Proxy.NO_PROXY.equals(proxy) && proxy != null && username != null && password != null) {
             var authenticator = new Authenticator() {
                 @Override

diff --git a/core-api/src/main/java/org/ariia/core/api/client/ChannelClient.java b/core-api/src/main/java/org/ariia/core/api/client/ChannelClient.java
@@ -21,13 +21,13 @@ public ChannelClient(Properties properties, ClientRequest clientRequest) {
         this(
                 properties,
                 clientRequest,
-                Executors.newCachedThreadPool(),
+                Executors.newVirtualThreadPerTaskExecutor(),
                 new ClientChannelWriter() {}
         );
     }
 
     public ChannelClient(Properties properties, ClientRequest clientRequest, ClientWriter clientWriter) {
-        this(properties, clientRequest, Executors.newCachedThreadPool(), new ChannelDownloader(clientRequest, clientWriter));
+        this(properties, clientRequest, Executors.newVirtualThreadPerTaskExecutor(), new ChannelDownloader(clientRequest, clientWriter));
     }
 
     public ChannelClient(Properties properties, ClientRequest clientRequest, ExecutorService executor,

diff --git a/core-api/src/main/java/org/ariia/core/api/client/SegmentClient.java b/core-api/src/main/java/org/ariia/core/api/client/SegmentClient.java
@@ -14,13 +14,13 @@
 
 public class SegmentClient extends Client implements StreamOrder, ThreadOrder {
 
-    private SegmentDownloader segmentDownloader;
+    private final SegmentDownloader segmentDownloader;
 
     public SegmentClient(Properties properties, ClientRequest clientRequest) {
         this(
                 properties,
                 clientRequest,
-                Executors.newCachedThreadPool(),
+                Executors.newVirtualThreadPerTaskExecutor(),
                 new SegmentDownloader(clientRequest, new SegmentWriter() {}))
         ;
     }

diff --git a/core-api/src/main/java/org/ariia/core/api/service/DownloadServiceFactory.java b/core-api/src/main/java/org/ariia/core/api/service/DownloadServiceFactory.java
@@ -31,7 +31,7 @@ public DownloadServiceBuilder builder() {
             builder.setSessionReport(sessionReportFactory);
         }
         if (Objects.isNull(scheduledService)) {
-            this.scheduledService = Executors.newScheduledThreadPool(SCHEDULE_POOL);
+            this.scheduledService = Executors.newScheduledThreadPool(SCHEDULE_POOL, Thread.ofVirtual().factory());
         }
         builder.setScheduledService(scheduledService);
         if (Objects.isNull(connectivityCheck)) {