Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forcing a unique login per user row, making sure code can handle it #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pkamps
Copy link
Member

@pkamps pkamps commented Jan 5, 2020

Background
The DB table ezuser allows non-unique values in the login column. That obviously does not make any sense. This pull request is changing the DB schema forcing unique values in the login column. It also adjusts the kernel code which is required to avoid fatal errors creating users in the admin backend.

Testing Instructions

  1. Checkout branch
  2. Update the DB schema: php update/run.php -u ezpub -p ezpub -d ezpub
  3. Login to the admin UI
  4. Create a new user account and send for publishing
  5. Create another new user account - make sure to pick exactly the same value for the 'username' field.
  6. Confirm that you don't get a 500 fatal error. You should see an input validation error message, saying that the username already exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant