Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for multiarch #12

Closed
wants to merge 1 commit into from
Closed

add support for multiarch #12

wants to merge 1 commit into from

Conversation

pkking
Copy link

@pkking pkking commented May 11, 2023

@pkking
Copy link
Author

pkking commented May 11, 2023

@mudler @monstermunchkin @TommyLike can you help to review

@@ -41,6 +41,10 @@ func main() {
Name: "keep",
Usage: "Keeps downloaded layers around (useful for debugging)",
},
cli.StringFlag{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Specify/specify
  2. Can we specify the default value here?

@@ -23,7 +23,25 @@ type DownloadOpts struct {
UnpackMode string
}

func DownloadAndUnpackImage(sourceImage, output string, opts *DownloadOpts) error {
func getTargetImageSha(hub *registry.Registry, repo, tag, arch string) (string, error) {
manifestList, err := hub.ManifestList(repo, tag)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have no manifest list for specific image?

@TommyLike
Copy link

@pkking thanks!

Signed-off-by: Li Chaoran <pkwarcraft@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants