Merge branch 'patch-2' of github.com:joscha/avsc into patch-2

mtth · Sep 24, 2024 · 87faea2 · 87faea2
2 parents 040aed7 + b540798
commit 87faea2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -22,7 +22,7 @@ jobs:
           - '18'
     name: Test using node ${{ matrix.node }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Install Node ${{ matrix.node }}
         shell: bash -eo pipefail -l {0}
         run: |

diff --git a/test/test_types.js b/test/test_types.js
@@ -831,6 +831,19 @@ suite('types', () => {
       function hook(path) { paths.push(path); }
     });
 
+    // via https://github.com/mtth/avsc/pull/469
+    test('synthetic constructor', () => {
+      const name = 'Foo';
+      const type = types.Type.forSchema([
+        'null',
+        {type: 'record', name: `test.${name}`, fields: [{name: 'id', type: 'string'}]},
+      ]);
+
+      const data = {id: 'abc'};
+      const roundtripped = type.fromBuffer(type.toBuffer(data));
+      assert.equal(roundtripped.constructor.name, name);
+      assert.deepEqual(roundtripped, data);
+    })
   });
 
   suite('EnumType', () => {