Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code blocks #16

Merged
merged 3 commits into from
Aug 18, 2021
Merged

Improve code blocks #16

merged 3 commits into from
Aug 18, 2021

Conversation

mtsknn
Copy link
Owner

@mtsknn mtsknn commented Aug 18, 2021

  • Replace highlight.js with Prism
  • Update styles
    • Before (third line highlighted for demo purposes only):
      Styles before the PR: darker colors, stuffy.
    • After:
      Styles after the PR: lighter colors, line highlight markers at the beginning of lines.
  • Fix visual bugs
    • Addition/deletion lines in diff code blocks had extra space below them on iOS Safari (Telegram converted the screenshot to JPG 🤦‍♂️):
      iOS Safari bug: extra space below highlighted lines in diff code blocks.
    • Long lines sometimes wrapped on iOS Safari:
      iOS Safari bug: a long line wrapping.
    • Identation of code blocks was off inside lists and blockquotes in XS screen size:
      Bug in XS screen size: indentation of code blocks inside lists were off.
  • Make code blocks focusable for keyboard accessibility

@netlify
Copy link

netlify bot commented Aug 18, 2021

✔️ Deploy Preview for mtsknn ready!

🔨 Explore the source changes: 22836c9

🔍 Inspect the deploy log: https://app.netlify.com/sites/mtsknn/deploys/611c9e820c212d000836d5ea

😎 Browse the preview: https://deploy-preview-16--mtsknn.netlify.app

@mtsknn mtsknn merged commit 74a9570 into master Aug 18, 2021
@mtsknn mtsknn deleted the code-blocks branch August 18, 2021 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant