Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin black to 2022 version #343

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Pin black to 2022 version #343

merged 1 commit into from
Feb 6, 2023

Conversation

mtreinish
Copy link
Owner

Black only provides backwards compatibility guarantees for each year's versions. The major version is the year which will not make any breaking format changes in that release. Since we're in 2023 now black has released a 23.x.y release which causes incompatible changes with our previously used 22.x.y version. In the short term to avoid failures caused by these unrelated changes this commit pins our version to 22.x.y. In the future we can upgrade this version and update the formatting with the new rules at that time.

Black only provides backwards compatibility guarantees for each year's
versions. The major version is the year which will not make any breaking
format changes in that release. Since we're in 2023 now black has
released a 23.x.y release which causes incompatible changes with our
previously used 22.x.y version. In the short term to avoid failures
caused by these unrelated changes this commit pins our version to
22.x.y. In the future we can upgrade this version and update the
formatting with the new rules at that time.
@codecov-commenter
Copy link

Codecov Report

Merging #343 (23910a8) into main (01fb398) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #343   +/-   ##
=======================================
  Coverage   61.21%   61.21%           
=======================================
  Files          30       30           
  Lines        2617     2617           
  Branches      470      433   -37     
=======================================
  Hits         1602     1602           
  Misses        891      891           
  Partials      124      124           
Flag Coverage Δ
unittests 61.21% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stestr/repository/file.py 80.45% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mtreinish mtreinish merged commit 883201c into main Feb 6, 2023
@mtreinish mtreinish deleted the pin-black branch February 6, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants