Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: pivot table #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: pivot table #49

wants to merge 1 commit into from

Conversation

dedobbin
Copy link

@dedobbin dedobbin commented May 5, 2020

Work in progress. Some things that need to be done from top of my head:

  • FE should check model exists.
  • When pivot model fields are left empty, should use default.
  • BelongsToMany relations are now 'pseudo-relations' in backend (A related to AB, AB related to A).
    Maybe would be better if these 'pseudo-relations' exist in frontend only, because they are only there for visuals, and aren't actual model relations. They are not stored though (outside of cache) so maybe it's fine this way.
  • Migrations for relations when generating pivot model with relations.
  • General clean, not all parts are 'equally elegant'. Also some TODOs can be found in the wild
  • I think belongsToManyMigrations dont delete correctly when the checkbox is used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant