Actually ensure the contents of pyproject.toml do not change after cleanup
#207
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
force-pushed
the
test-pep621-contents-cleanup
branch
4 times, most recently
from
c24d0b3 to
e2534a4
Compare
edgarrmondragon
force-pushed
the
test-pep621-contents-cleanup
branch
from
e2534a4 to
a61e80b
Compare
edgarrmondragon
commented
Jan 10, 2025
| @@ -668,7 +668,7 @@ def _get_and_apply_version( | |||
| elif pep621: | |||
| name = pyproject["project"]["name"] | |||
| original = pyproject["tool"]["poetry"]["version"] | |||
| dynamic_array = pyproject["project"]["dynamic"].copy() | |||
| dynamic_array = pyproject["project"]["dynamic"] | |||
There was a problem hiding this comment.
Turns out .copy() gets you the underlying list, not an tomlkit.item.Array.
There was a problem hiding this comment.
I wouldn't have guessed either 😅 Thanks for catching that.
edgarrmondragon
changed the title
pyproject.toml do not change after cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now with tests...
Related:
dynamicarray for PEP 621 #206 should've been