-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rustix from 0.38.14 to 0.38.21 #2159
Conversation
@dependabot rebase |
Sorry, only users with push access can use that command. |
@dependabot rebase |
485cce9
to
0b6c2e1
Compare
Weird. |
What's wrong, the failed tests? |
The tests themselves succeeded, but uploading the result files is failing with an authorization error. I thought it might be spurious but it happened twice. |
Unless a workflow explicitly requests write access the GITHUB_TOKEN for dependabot is read-only. https://docs.github.com/en/code-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions I think this is the problem here. |
Ok so the error is:
So I guess for it to work it would need the checks permission, like this:
See also: https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#create-a-check-run The other option is to disable the upload steps specifically for dependabot runs. I don't see a reason why to not allow dependabot PRs to upload PR checks. If there are no objections I'll open a PR to add this. |
We can try |
@dependabot rebase |
Bumps [rustix](https://github.com/bytecodealliance/rustix) from 0.38.14 to 0.38.21. - [Release notes](https://github.com/bytecodealliance/rustix/releases) - [Commits](bytecodealliance/rustix@v0.38.14...v0.38.21) --- updated-dependencies: - dependency-name: rustix dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
0b6c2e1
to
7fa4cb7
Compare
Bumps rustix from 0.38.14 to 0.38.21.
Commits
cf2ad7f
chore: Release rustix version 0.38.214186613
Miscellaneous documentation cleanups.bde49f1
Adjust sockaddr lengths for illumos in more more place. (#904)b0a83ce
Add connect_unspec (#903)b01b482
Fix getsockopt zeroing memory (#901)36e3999
Fix a test failures on illumos. (#900)1ab21e6
Fix p{read,write}v{,v2}'s encoding of the offset argument on Linux. (#896)0b7ccf4
Miscellaneous documentation cleanups. (#894)3f338d8
Fix miscellaneous clippy lints. (#893)e2314b7
Fixrenameat_with
with flags on Android. (#892)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.