Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for packages that contain a given class #26

Closed
wants to merge 2 commits into from

Conversation

maddingo
Copy link

@maddingo maddingo commented Jan 5, 2022

The new command class-search lists the packages that contain a certain class, given by its full name

Copy link
Owner

@mthmulders mthmulders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maddingo, first of all, thanks for your contribution. I like the idea, it's very useful, and look forward to including it in a future release of MCS!

Since this is still a way of searching, I feel it would make more sense to have a CLI like this: mcs search -c the.class.i.need, or long version mcs search --class the.class.i.need.

@maddingo
Copy link
Author

maddingo commented Jan 11, 2022

@mthmulders I still feel that using a new search command is adequate.
What would mcs search -c LogManager log4j do? should it do a search for both an artifact that contains log4j and a library that contains a class Logmanager. Should it be the intersection of both?

Having two distinct search command emphasizes that these are two different searches. What do you think?
Since you have don some significant changes in your code I will redact this PR and re-submit it.

@maddingo maddingo closed this Jan 11, 2022
@maddingo
Copy link
Author

I will resubmit the feature in another PR due to lot of changes in the target branch

@maddingo maddingo deleted the main branch January 11, 2022 23:50
@mthmulders
Copy link
Owner

I'm sorry for the inconvenience the refactoring may have caused. Perhaps it's easier to propose the changes on a separate branch?

I'll get back to the command/flag matter, hopefully later today.

@mthmulders
Copy link
Owner

@all-contributors please add @maddingo for code.

Copy link
Contributor

@mthmulders

I've put up a pull request to add @maddingo! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants