-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search for packages that contain a given class #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @maddingo, first of all, thanks for your contribution. I like the idea, it's very useful, and look forward to including it in a future release of MCS!
Since this is still a way of searching, I feel it would make more sense to have a CLI like this: mcs search -c the.class.i.need
, or long version mcs search --class the.class.i.need
.
…s not thrown, by request of project owner
@mthmulders I still feel that using a new search command is adequate. Having two distinct search command emphasizes that these are two different searches. What do you think? |
I will resubmit the feature in another PR due to lot of changes in the target branch |
I'm sorry for the inconvenience the refactoring may have caused. Perhaps it's easier to propose the changes on a separate branch? I'll get back to the command/flag matter, hopefully later today. |
@all-contributors please add @maddingo for code. |
I've put up a pull request to add @maddingo! 🎉 |
The new command class-search lists the packages that contain a certain class, given by its full name