Fix @types/superagent has no default export

[scottc]

Fix @types/superagent has no default export.
Although this might be an issue with the "@types/superagent": "^4.1.0" type definition.

With typescript "strict": true, config enabled, doesn't allow implicit any type.

TS1192: Module '"C:/_/node_modules/@types/superagent/index"' has no default export.

TS7006: Parameter 'error' implicitly has an 'any' type.

TS7006: Parameter 'response' implicitly has an 'any' type.

[mtennoe]

Thanks for contributing @scottc!

Looks good! Quick question: Would an updated version of the @types/superagent+superagent packages help address this as well?

[scottc]

I tried:

@types/superagent@4.1.0 // latest
@types/superagent@4.0.0 // doesn't exist
@types/superagent@3.8.3

superagent@4.1.0 // latest
superagent@4.0.0 // currently used by swagger-typescript-codegen
superagent@3.8.3

All versions listed above export via module.exports = request;
https://github.com/visionmedia/superagent/blob/8580c4f5c4f515fdc2f703b41f0affed4613e958/lib/node/index.js#L47

In ES5, the equivalent of an ES6 default export would be module.exports.default = request;

So I'm inclined to believe that the @types/superagent typedef package is correct / accurate. That there is no default export.

// single import
const get = require('superagent').get;
import { get } from "superagent";

// entire module import
const request = require('superagent');
import * as request from "superagent";

// default import
const request = require('superagent').default;
import request from "superagent";

If this is confusing, might be worth making a pull request to superagent, to expose request as the default export.

[mtennoe]

Thanks for clarifying!
Might be worth doing the PR against superagent, but not that urgent IMO. If we see confusion around this though we can do that sooner.

Thanks for fixing this!

[mtennoe]

@scottc - Merged and published as 1.9.4

[sbusch]

FYI, there's a new major release 5.0.0 for superagent pending, with changes regarding packaging. It could be released soon, possibly in the next few hours. Although I'm no expert, this could impact importing as well. See here: ladjs/superagent#1423

[mtennoe]

Thanks for the heads up @sbusch! Will be interesting to try out that version