Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO markers should only be detected at comment start #52

Closed
pmcoz opened this issue Mar 5, 2017 · 4 comments
Closed

TODO markers should only be detected at comment start #52

pmcoz opened this issue Mar 5, 2017 · 4 comments

Comments

@pmcoz
Copy link

pmcoz commented Mar 5, 2017

Currently, comments such as
// Here, we look for strings containing TODO
are picked up as TODO tasks. This is rarely a problem when using TODO, but can be more of a problem when using other markers. Would it be preferable to ensure that the marker is at the start of the comment text before considering it to be a task?

@mt40
Copy link
Owner

mt40 commented Mar 18, 2017

Thanks for reporting this.
Which programming language is used?
Could you provide me a sample of your code file that contains that comment?

@pmcoz
Copy link
Author

pmcoz commented Mar 18, 2017

Language is JS.

I can do better than provide a sample of my code: I can provide a sample of YOUR code! :)
todo.zip

This case is unusal enough to ignore, but the issue could be more of a problem if one used a marker such as FIX, and had a comment such as // This code is to fix a rounding problem

@mt40 mt40 mentioned this issue Mar 18, 2017
@mt40 mt40 closed this as completed in #56 Mar 18, 2017
mt40 added a commit that referenced this issue Mar 18, 2017
* Fix incorrectly accept markers in the middle of a string (#52).

* Add built packages.
@mt40 mt40 added the bug label Mar 18, 2017
@mt40
Copy link
Owner

mt40 commented Mar 18, 2017

Thanks, will include the fix in the next version 👍

@pmcoz
Copy link
Author

pmcoz commented Mar 18, 2017

Thanks!

Let me add that I wouldn't use VS Code if it wasn't for this extension of yours; it's just SO useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants