Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the shell arguments directly to bash #44

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Pass the shell arguments directly to bash #44

merged 2 commits into from
Jul 14, 2020

Commits on Jul 14, 2020

  1. Pass the shell arguments directly to bash 

    This allows us to run the "run" script using "set -eo pipefail" by default.

The previous wrapper executed the arguments as a bash command string, which
allowed the user to run any command, but didn't give us a chance to special case
if the argument was a script passed from the GHA "run" command.

This is a breaking change.

Porting guide:

* Instead of `msys2 mybinary` you now have to run `msys2 -c 'mybinary'`
* To revert the bash error settings you can use `set +e` and `set +o pipefail`
  in your run script
    @lazka
    lazka committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    13553f6 View commit details
    Browse the repository at this point in the history

  2. README: Add a note re running commands in cmd/powershell using -c

    @lazka
    lazka committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    0083772 View commit details
    Browse the repository at this point in the history