Route "Device Status Report" responses correctly #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two instances of pty pipes have been forgotten somewhere along the lines. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
When launching an MSYS2 process via a non-MSYS2 process, the response for, say, a CSI [ 6n (Device Status Report) sent from that MSYS2 process was sometimes not sent (or sent only partially) to the process but to the terminal instead. This regression was introduced in f206417 (Cygwin: pty: Reduce unecessary input transfer., 2021-02-11). While it is not yet completely clear why, this patch fixes this. The explanation is left for the commit message that Takashi will craft for the Cygwin project, but we will take this patch early into the MSYS2/Git for Windows projects. This addresses git-for-windows/git#3579
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in git-for-windows/git#3579, when using MSYS2 runtime v3.3.3 in a regular Git Bash, after
git config -e --globallaunchedvimand the editor was closed, seemingly random characters are "ghost-typed". Concretely, I saw1R77;30502;0c10;rgb:bfbf/bfbf/bfbf11;rgb:0000/0000/0000being "ghost-typed" every time Git had called vi for editing a file.To be precise, the hexdump -C output is this:
This is the response for a
CSI [ 6nrequest, and the response was clearly routed to the terminal by mistake instead of the process that requested it.The regression was actually introduced into v3.2.0, but not noticed earlier. I reported the issue after trying to figure out a workaround for three days, without success, and the original author of the commit introducing the regression provided a patch that works around it. I do not yet understand the patch, but let's take the patch for now because the regression is pretty severe.
While at it, also include a fixup that handles two previously unhandled instances of the
cygwin-ptypipe (which is renamed tomsys-ptyin MSYS2) that I spotted while working on this bug.