Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msys2-runtime-3.3: build as msys2-runtime on i686 #5188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lazka
Copy link
Member

@lazka lazka commented Feb 3, 2025

So there is an automated upgrade path and users don't have to manually switch to msys2-runtime-3.3.

@lazka
Copy link
Member Author

lazka commented Feb 3, 2025

@jeremyd2019 does this make sense/help?

@jeremyd2019
Copy link
Member

I don't know. Would it be possible to do a conflicts/replaces thing, either on msys2-runtime-3.3, or on this new msys2-runtime against msys2-runtime-3.3, or would that cause issues with pacman?

So there is an automated upgrade path and users don't
have to manually switch to msys2-runtime-3.3.
@lazka lazka force-pushed the msys2-runtime-3.3-i686-rename branch from 57f8e96 to b362b85 Compare February 4, 2025 16:42
@lazka
Copy link
Member Author

lazka commented Feb 4, 2025

Ah, sure, like this?

@jeremyd2019
Copy link
Member

I'll try to test this today

Comment on lines +307 to +313
package_msys2-runtime() {
pkgdesc="Posix emulation engine for Windows"
options=('!strip')
conflicts=('catgets' 'libcatgets' 'msys2-runtime-3.3')
replaces=('catgets' 'libcatgets' 'msys2-runtime-3.3')

package_msys2-runtime-3.3
Copy link
Member

@jeremyd2019 jeremyd2019 Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I kind of expected, this didn't work:

$ pacman -Qip msys2-runtime-3.3.6-14-i686.pkg.tar.zst
Name            : msys2-runtime
Version         : 3.3.6-14
Description     : Posix emulation engine for Windows
Architecture    : i686
URL             : https://www.cygwin.com/
Licenses        : GPL
Groups          : None
Provides        : msys2-runtime=3.3.6
Depends On      : None
Optional Deps   : None
Conflicts With  : catgets  libcatgets  msys2-runtime  msys2-runtime-3.5
Replaces        : catgets  libcatgets
Compressed Size : 2.57 MiB
Installed Size  : 9.79 MiB
Packager        : Unknown Packager
Build Date      : Tue, Feb 4, 2025 1:14:50 PM
Install Script  : No
Validated By    : None
Signatures      : None

In some cases, makepkg effectively greps the function for the variable definitions, but in others it relies on their values after running the function. In the former case, it would see the definitions here, but in the latter the values set in package_msys2-runtime-3.3 would have overwritten them. It seems the former is done for making the .SRCINFO and the latter is done for making the binary packages themselves.

pkgname = msys2-runtime
        pkgdesc = Posix emulation engine for Windows
        conflicts = catgets
        conflicts = libcatgets
        conflicts = msys2-runtime-3.3
        replaces = catgets
        replaces = libcatgets
        replaces = msys2-runtime-3.3
        options = !strip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants