Update graphql-query-batching.mdx #446
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix errors in sample code
|
@dougalg-js-tw is attempting to deploy a commit to the MSW Team on Vercel. A member of the Team first needs to authorize it. |
kettanaito
requested changes
Feb 10, 2025
| // Construct an individual query request | ||
| // to the same URL but with an unwrapped query body. | ||
| const queryRequest = new Request(request, { | ||
| const queryRequest = new Request(request.clone(), { |
There was a problem hiding this comment.
What do you think if we cloned the request once at the beginning of the resolver? The fewer clones, the better.
const requestClone = request.clone()
const payload = await requestClone.json()
// ...
new Request(requestClone, { ... })This would be a good recommendation for the docs.
dougalg-js-tw
commented
Feb 11, 2025
websites/mswjs.io/src/content/docs/recipes/graphql-query-batching.mdx
Outdated
Show resolved
Hide resolved
dougalg-js-tw
commented
Feb 11, 2025
Move clone to top and only clone once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix errors in sample code. This code should now mostly run as-is, without errors