Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): support windows paths in the init command #2260

Conversation

ivanfernandez2646
Copy link
Contributor

@ivanfernandez2646 ivanfernandez2646 commented Sep 3, 2024

@kettanaito kettanaito changed the title test(node msw api cli): update cli init (normalizing folders) fix(cli): support windows paths in the init command Sep 4, 2024
@kettanaito kettanaito added bug Something isn't working DX labels Sep 4, 2024
@kettanaito
Copy link
Member

Hey, @ivanfernandez2646 👋 Thank you so much for adding the tests!

I've pushed the fix so now the init command can support both Windows and Unix paths stored in workerDirectory or provided as an argument in the CLI.

Copy link
Member

@kettanaito kettanaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Waiting for the CI before merging.

@kettanaito kettanaito merged commit ba285b8 into mswjs:main Sep 4, 2024
11 checks passed
@kettanaito
Copy link
Member

Welcome to the contributors, @ivanfernandez2646 👏

@kettanaito
Copy link
Member

Released: v2.4.2 🎉

This has been released in v2.4.2!

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.


Predictable release automation by @ossjs/release.

@nabby27
Copy link

nabby27 commented Sep 4, 2024

Congratulations @ivanfernandez2646 for your contribution!

Although it is not a solution to the issue (since the problem did not exist), I will still pay you the Opire bounty for contributing to the project by creating the tests!

@ivanfernandez2646
Copy link
Contributor Author

@kettanaito @nabby27 Many thanks!! It was a pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cross platform path support to workerDirectory
3 participants