fix(HttpResponse): skip setting "Content-Length" if it is already set #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
commented
Aug 1, 2024
| @@ -137,7 +137,7 @@ export class HttpResponse extends Response { | |||
| static arrayBuffer(body?: ArrayBuffer, init?: HttpResponseInit): Response { | |||
| const responseInit = normalizeResponseInit(init) | |||
|
|
|||
| if (body) { | |||
| if (body && !responseInit.headers.has('Content-Length')) { | |||
There was a problem hiding this comment.
Added the missing check.
28 tasks
Released: v2.3.5 🎉This has been released in v2.3.5! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
This was referenced Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading @mswjs/interceptors to 0.33 (in #2011), I've noticed a failing mocked binary response test: it was listing the
Content-Lengthheader value twiceWarning
This indicates a deeper issue, as
.set()onHeadersinstance must not join values. Something goes off here. RawHeadersfrom Undici behaved correctly on that branch.We don't have any check if the
Content-Lengthresponse header has already been set onHttpResponse.arrayBuffer(), which means MSW will disregard your customContent-Length, which is a bug.